Fix issue of wrong results when querying external label values #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
results. Add new tests for such cases.
dmitrime
commented
May 5, 2023
| @@ -58,6 +58,12 @@ func testLabelAPIs(t *testing.T, startStore func(extLset labels.Labels, append f | |||
| {start: timestamp.FromTime(minTime), end: timestamp.FromTime(maxTime), expectErr: errors.New("rpc error: code = InvalidArgument desc = label name parameter cannot be empty")}, | |||
| {start: timestamp.FromTime(minTime), end: timestamp.FromTime(maxTime), label: "foo"}, | |||
| {start: timestamp.FromTime(minTime), end: timestamp.FromTime(maxTime), label: "region", expectedValues: []string{"eu-west"}}, // External labels should be visible. | |||
There was a problem hiding this comment.
It's uncertain whether this test should pass? There are no series, but external label is returned anyway? I didn't touch it because the comment says it should be visible. In case you agree that it's wrong too, I can tweak the PR to account for that (we would need to check len(vals) > 0 returned from storepb.LabelValuesResponse).
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
Fixed in #6816, sorry not taking a look at your PR. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a try at issue #6338
You may have more context or ideas how to improve it.
Changes
Removed code that immediately returns external label value. Added code that returns its value after matching is done.
Verification
Added new tests.